Skip to content

Move UmaskGuard in uucore and use it for mkdir, mkfifo & mknod#10310

Open
sylvestre wants to merge 6 commits intouutils:mainfrom
sylvestre:followup-10036
Open

Move UmaskGuard in uucore and use it for mkdir, mkfifo & mknod#10310
sylvestre wants to merge 6 commits intouutils:mainfrom
sylvestre:followup-10036

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 18, 2026

followup of #10036

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sylvestre:followup-10036 (64c9dda) with main (938039e)

Summary

✅ 142 untouched benchmarks
⏩ 180 skipped benchmarks1

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre mentioned this pull request Jan 18, 2026
Open
@github-actions
Copy link

github-actions bot commented Jan 18, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ptx/ptx-overrun is no longer failing!

@ChrisDryden ChrisDryden mentioned this pull request Jan 19, 2026
Closed
ChrisDryden
ChrisDryden reviewed Jan 19, 2026
View reviewed changes
src/uucore/src/lib/features/mode.rs
}

#[test]
#[cfg(unix)]
Copy link
Collaborator

@ChrisDryden ChrisDryden Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing because the coverage tests use -Cpanic=abort so they don't have catch_unwind

You can add:

#[cfg(panic = "unwind")]

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Jan 19, 2026

I think we have to be careful adding umask integration tests when its running multi-threaded because the UMaskGuard affects the process, when stress testing it the tests were flaky. Maybe adding a Mutex in the unit tests?

Might be good to add a comment in the helper function:

  /// Note: umask is process-wide, so this guard is not thread-safe.
  /// Concurrent use from multiple threads will cause race conditions.

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDryden ChrisDryden ChrisDryden left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @ChrisDryden